APT-576 adding functionality to check if all orgs are the same in foreman.toml #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZoteTheMighty
suggested changes
Sep 29, 2023
Co-authored-by: Paul Doyle <[email protected]>
amatosov-rbx
reviewed
Oct 2, 2023
src/configFile.ts
Outdated
| } | ||
| const manifestContent = parse(data); | ||
| const sameGithubOrgSource = checkSameOrgToolSpecs(manifestContent, org); | ||
| if (sameGithubOrgSource == false) { |
There was a problem hiding this comment.
Suggested change
| if (sameGithubOrgSource == false) { | |
| if (!sameGithubOrgSource) { |
general practice for all languages (especially C/C++) is to never compare bools on equality to bool constants
in JS null, undefined and false are interchangeable in different functions.
It is strongly recommended to use if (var) and if (!var) to make code change proof
There was a problem hiding this comment.
I feel like we need to add linter...
There was a problem hiding this comment.
This repo uses eslint
|
Anton and I synced offline and it seems like explicit null checks are recommended https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/docs/rules/strict-boolean-expressions.md |
ZoteTheMighty
approved these changes
Oct 3, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to be able to enforce the same tool source orgs at the setup-foreman step of CI.
This behavior should be the default, but can be bypassed with the
allow-external-github-orgsoption